Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect the :color option #47

Open
Roger-luo opened this issue Jun 24, 2021 · 4 comments
Open

respect the :color option #47

Roger-luo opened this issue Jun 24, 2021 · 4 comments

Comments

@Roger-luo
Copy link

currently the show method overloaded in this package doesn't respect the :color option in julia IO, which as a result will print extra ASCII chars in Pluto.

@KristofferC
Copy link
Owner

Yes, it is difficult though because people want to be able to e.g. interpolate "crayons" and then you don't have an IO.

I think we need to do a breaking release to clear these things up.

@DilumAluthge
Copy link

DilumAluthge commented Aug 29, 2021

I think that this is the cause of JuliaData/DataFrames.jl#2846.

In that particular issue, they are testing output by using sprint to get the output into a string, and then checking that the output string contains the ASCII escape sequences for the colors. So in that use case, they always want the ASCII escape sequences to be included in the string, even if Julia was e.g. started with --color=no.

cc: @bkamins

@Roger-luo
Copy link
Author

I guess there should be a new string type to solve the string interpolation with color problem? the new string type stores the colored string as list of String with meta info about the color (format etc.) on it?

@Roger-luo
Copy link
Author

Now LazyString PR is merged, maybe should consider that as a solution to this issue? Basically, when someone wants to interpolating the Crayons, always suggest to use LazyString instead of normal ones, so we always have the context of IO when actually printing the Crayons, What do people think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants