From 76fac78909b080ddf0c7d2e332e1a47880017df7 Mon Sep 17 00:00:00 2001
From: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Date: Sat, 7 Dec 2024 18:29:49 +0100
Subject: [PATCH] Run code style checks in workflow only once (#3648)

It's enough if the code style checks are successful once, it's not
necessary to run them with every node version.

Also, if there is an error, we can see more quickly whether it is a code
style or a test-runner issue.
---
 .github/workflows/automated-tests.yaml | 24 ++++++++++++++++++++----
 CHANGELOG.md                           | 12 ++++++++----
 2 files changed, 28 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/automated-tests.yaml b/.github/workflows/automated-tests.yaml
index cf083cbf46..8de8a641c7 100644
--- a/.github/workflows/automated-tests.yaml
+++ b/.github/workflows/automated-tests.yaml
@@ -13,6 +13,26 @@ permissions:
   contents: read
 
 jobs:
+  code-style-check:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - name: "Checkout code"
+        uses: actions/checkout@v4
+      - name: "Use Node.js"
+        uses: actions/setup-node@v4
+        with:
+          node-version: 23
+          cache: "npm"
+      - name: "Install dependencies"
+        run: |
+          npm run install-mm:dev
+      - name: "Run linter tests"
+        run: |
+          npm run test:prettier
+          npm run test:js
+          npm run test:css
+          npm run test:markdown
   test:
     runs-on: ubuntu-latest
     timeout-minutes: 30
@@ -36,8 +56,4 @@ jobs:
           Xvfb :99 -screen 0 1024x768x16 &
           export DISPLAY=:99
           touch css/custom.css
-          npm run test:prettier
-          npm run test:js
-          npm run test:css
-          npm run test:markdown
           npm run test
diff --git a/CHANGELOG.md b/CHANGELOG.md
index af4a01a28f..1c9481b479 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,14 +16,18 @@ _This release is scheduled to be released on 2025-01-01._
 - [core] Add wayland and windows start options to `package.json` (#3594)
 - [docs] Add step for npm publishing in release process (#3595)
 - [core] Add GitHub workflow to run spellcheck a few days before each release (#3623)
-- [core] Add test flag to index.html to pass to module js for test mode detection (needed by #3630)
+- [core] Add test flag to `index.html` to pass to module js for test mode detection (needed by #3630)
 - [core] Add export on animation names (#3644)
-- [compliments] add support for refreshing remote compliments file, and test cases (#3630)
+- [compliments] Add support for refreshing remote compliments file, and test cases (#3630)
 - [linter] Re-add `eslint-plugin-import`now that it supports ESLint v9 (#3586)
 - [linter] Re-activate `eslint-plugin-package-json` to lint `package.json` (#3643)
-- [linter] Add linting for markdown files.
+- [linter] Add linting for markdown files (#3646)
 - [calendar] - added ability to display end date for full date events, where end is not same day (showEnd=true)
 
+### Changed
+
+- [core] Run code style checks in workflow only once.
+
 ### Removed
 
 - [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575)
@@ -31,7 +35,7 @@ _This release is scheduled to be released on 2025-01-01._
 
 ### Updated
 
-- [repo] reactivated `stale.yaml` as github action to mark issues as stale after 60 days and close them 7 days later (if no activity)
+- [repo] Reactivate `stale.yaml` as GitHub action to mark issues as stale after 60 days and close them 7 days later (if no activity) (#3577, #3580, #3581)
 - [core] Update electron dependency to v32 (test electron rebuild) and other dependencies too
 - [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container)
 - [core] Run and test with node 23 (#3588)