Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTC timezone #9

Open
iofane opened this issue Jul 5, 2024 · 1 comment
Open

UTC timezone #9

iofane opened this issue Jul 5, 2024 · 1 comment

Comments

@iofane
Copy link

iofane commented Jul 5, 2024

Firstly, thanks for the great app.
There's an issue in tagging.py that the datetime.fromisoformat() method doesn't support 'Z' at the end of the timestamp. This prevents downloading.

example error:
File "C:\shira\shiradl\tagging.py", line 48, in metadata_applier v = datetime.fromisoformat(str(v)).date() ValueError: Invalid isoformat string: '2015-08-02T00:00:00Z'

Fix: in tagging.py
swapped out from datetime import datetime to from dateutil import parser
swapped out v = datetime.fromisoformat(str(v)).date() to v = parser.isoparse(str(v)).date()

The dateutil library seems to just handle UTC 'Z' easier.

Alternatively having a timezone cli option could help me to set something up from the get go.

@KraXen72
Copy link
Owner

KraXen72 commented Jul 8, 2024

ah, okay. i didn't know about dateutil. i'll work on a fix. thanks for letting me know what you did to fix it.
i'm just glad the app is getting so many users :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants