Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make column-span work for columns grandchildren #980

Open
fabiobatalha opened this issue Oct 28, 2019 · 2 comments
Open

Make column-span work for columns grandchildren #980

fabiobatalha opened this issue Oct 28, 2019 · 2 comments
Labels
bug Existing features not working as expected

Comments

@fabiobatalha
Copy link

fabiobatalha commented Oct 28, 2019

I did some tests to test the merge-request (#878)

This merge request is related to the issue: #719

I took the same article displayed in the issue #719 and tried to produce the PDF file.

No changes were noticed on the PDF preview.

WeasyPrint version: v50

The original files are available in the zip below:

column-span.zip

Expected result:

expected

Got:

got

@Tontyna
Copy link
Contributor

Tontyna commented Oct 29, 2019

As the title of #878 announces: It's only a partial support.
Of course, column-span: all should span across all columns of the nearest multicol ancestor but at the moment it looks like it only manages to span across the columns of the parent element.

That's why the footnote's title spans across the page, but the figures and tables don't.

BTW: It's your lucky day that WeasyPrint ignores the figures and tables and doesnt crash in the footnote, see #984

@liZe liZe changed the title column-span still not working Make column-span work for colmuns grandchildren Nov 8, 2019
@liZe liZe changed the title Make column-span work for colmuns grandchildren Make column-span work for columns grandchildren Nov 8, 2019
@liZe
Copy link
Member

liZe commented Nov 8, 2019

Of course, column-span: all should span across all columns of the nearest multicol ancestor but at the moment it looks like it only manages to span across the columns of the parent element.

Exactly. The code currently looks at the children to find column-span: all, but not at their own children.

Changing this behavior is not that easy, because we don't want to check all the grandchildren (nested columns, for example), we probably have to take care about some CSS properties like display and position, and we'll have to split the children using a resume_at / skip_stack tuple instead of a simple index.

@liZe liZe added the bug Existing features not working as expected label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing features not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants