TypeError: unsupported operand type(s) for +: 'float' and 'str'

[vildric]

Issues #800 state that its fixed, but looks like it is not.

Django==1.11.16
WeasyPrint==46

  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/__init__.py", line 211, in write_pdf
    font_config=font_config).write_pdf(
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/__init__.py", line 168, in render
    font_config)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/document.py", line 366, in _render
    [Page(p, enable_hinting) for p in page_boxes],
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/document.py", line 366, in <listcomp>
    [Page(p, enable_hinting) for p in page_boxes],
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/__init__.py", line 133, in layout_document
    context, root_box, html, cascaded_styles, computed_styles, pages))
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 807, in make_all_pages
    i, context, root_box, html, cascaded_styles, computed_styles)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 744, in remake_page
    page_number, page_state)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/pages.py", line 555, in make_page
    positioned_boxes, positioned_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 80, in block_level_layout_switch
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 134, in block_box_layout
    page_is_empty, absolute_boxes, fixed_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 515, in block_container_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 80, in block_level_layout_switch
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 134, in block_box_layout
    page_is_empty, absolute_boxes, fixed_boxes, adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 515, in block_container_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 64, in block_level_layout
    adjoining_margins)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/blocks.py", line 95, in block_level_layout_switch
    device_size, page_is_empty, absolute_boxes, fixed_boxes)
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/layout/flex.py", line 128, in flex_layout
    child.position_y = parent_box.content_box_y()
  File "/home/vagrant/.venv/lib/python3.6/site-packages/weasyprint/formatting_structure/boxes.py", line 167, in content_box_y
    return self.position_y + self.margin_top + self.padding_top + \
TypeError: unsupported operand type(s) for +: 'float' and 'str'

[liZe]

Hello,

Could you please provide a HTML sample?

[picturedots]

You can reproduce the problem with:
weasyprint http://www.loan-street.com ./output.pdf

And here is the version that I used:

root@c9992a4b668c:/code# weasyprint --version
/usr/local/lib/python3.7/site-packages/weasyprint/document.py:34: UserWarning: There are known rendering problems and missing features with cairo < 1.15.4. WeasyPrint may work with older versions, but please read the note about the needed cairo version on the "Install" page of the documentation before reporting bugs. http://weasyprint.readthedocs.io/en/latest/install.html
  'There are known rendering problems and missing features with '
WeasyPrint version 47

[Tontyna]

This is, similar to #910, another case of auto not being resolved to a pixel value. This time in the flex department. Snippet to reproduce the crash:

<style>
.flexcrash{
    margin-top: auto;
    display: flex;
}
</style>
<div class="flexcrash">
  XXX
</div>

Flex combined with a top margin of auto crashes, when Box.content_box_y tries to return self.position_y + self.margin_top + self.padding_top and can't add 'auto' to the floats.

Problem seems to be the BlockBox that WeasyPrint is forced to create as the child of the FlexBox (required by the XXX)

When the auto margins are applied to a separate child div, WeasyPrint doesn't crash:

<style>
.parent {
    display: flex;
    height:400px;
}
.child {
  margin: auto;
  background-color: red;
  width: 100px;
  height: 100px;    
}
</style>
<div class="parent">
<div class="child">
  XXX
</div>

Though it doesn't get the peculiar magic of flexbox and auto margins right -- the red square is centered horizontally but not vertically.

[liZe]

Auto margins on flex containers are now ignored. It's not a great solution, but at least it doesn't crash.

We should really add more tests for flexbox (#601) and fix the insane number of TODOs.