Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when elements with no break points and multiple flows are higher than a page #273

Closed
pjen opened this issue Oct 13, 2015 · 4 comments
Closed

Don't crash when elements with no break points and multiple flows are higher than a page #273

pjen opened this issue Oct 13, 2015 · 4 comments
Labels
crash Problems preventing documents from being rendered
Milestone
47

Comments

@pjen
Copy link

pjen commented Oct 13, 2015

minimal example:

<body>
    <table>
        <thead>
            <tr>
                <th>Column 1</th>
                <th>Column 2</th>
                <th>Column 3</th>
                <th>Column 4</th>
                <th>Column 5</th>
                <th>Column 6</th>
                <th>Column 7</th>
            </tr>
        </thead>

        [% FOREACH group IN [1 .. 10] %]
            <tbody style="page-break-inside: avoid">
                [% FOREACH count IN [1 .. 20] %]
                    <tr>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                        <td>[% count %]</td>
                    </tr>
                [% END %]
            </tbody>
        [% END %]
    </table>
</body>

Problem occurs when I group rows with <tbody style="page-break-inside: avoid"> together. This works if the rows are few enough that they fit onto a page (in my example I used the A4 landscape format for my page). If they exceed the page weasyprint hangs forever without any warnings. The content of the cells doesn't matter. The error occurs even if all cells are empty.

Version 0.24
@liZe
Copy link
Member

liZe commented Jan 11, 2016

Related to #209

@liZe liZe added the crash Problems preventing documents from being rendered label Jan 11, 2016
@liZe
Copy link
Member

liZe commented Jan 17, 2016

And related to #36.

@liZe liZe added the bug Existing features not working as expected label Mar 8, 2016
@liZe liZe changed the title Grouping table rows with <tbody style="page-break-inside: avoid"> - weasyprint hangs Don't crash when elements with no break points and multiple flows are higher than a page Aug 18, 2017
This was referenced Aug 18, 2017
Closed
Closed
@vojkny
Copy link

vojkny commented Apr 5, 2018

Will this ever be solved? :-)

@liZe liZe removed the bug Existing features not working as expected label Mar 7, 2019
@liZe liZe closed this as completed in 29820d6 Mar 22, 2019
@liZe liZe added this to the 46 milestone Mar 22, 2019
@liZe
Copy link
Member

liZe commented Mar 22, 2019

Will this ever be solved? :-)

Today is a BIG DAY! 🎉

@liZe liZe modified the milestones: 46, 47 Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash Problems preventing documents from being rendered
Projects
None yet
Milestone
47
Development

No branches or pull requests
3 participants
@vojkny @liZe @pjen