Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list-style-type as content being ignored #1206

Closed
muzzamilkhan opened this issue Sep 1, 2020 · 3 comments
Closed

list-style-type as content being ignored #1206

muzzamilkhan opened this issue Sep 1, 2020 · 3 comments
Labels
feature New feature that should be supported good first issue Issues that can be quite easily solved by Python developers with a good CSS background
Milestone
52

Comments

@muzzamilkhan
Copy link

With CSS3 introducing content being set as list-style-type, this is being ignored by Weasyprint:

CSS:
ul {list-style-type: '-';} ul ul {list-style-type: '+';}

Console error:
WARNING: Ignored list-style-type:\"-\" at **, invalid value.
WARNING: Ignored list-style-type:\"+\" at **, invalid value.
@liZe liZe added feature New feature that should be supported good first issue Issues that can be quite easily solved by Python developers with a good CSS background labels Sep 2, 2020
@malnajdi
Copy link
Contributor

malnajdi commented Oct 2, 2020

Hey, I tested this with the master branch and it seems it's working.

<html>
<head>
 <style>
   ul {list-style-type: '-';}
   ul ul {list-style-type: '+';}
 </style>
</head>
<body>
  <ul>
    <li>Homammed<li>
    <ul>
      <li>Homammed<li>
    </ul>
  </ul>
</body>
</html>

image

@liZe
Copy link
Member

liZe commented Oct 2, 2020 •
edited
Loading

Hey, I tested this with the master branch and it seems it's working.

There’s no code in WeasyPrint to handle that, and I get:

WARNING: Ignored `list-style-type: "-"` at 2:8, invalid value.
WARNING: Ignored `list-style-type: "+"` at 3:11, invalid value.

I don’t know how it could work for you 😄.

EDIT: you’re right, it’s fixed by 473443c.

@liZe
Copy link
Member

liZe commented Oct 2, 2020

Hey, I tested this with the master branch and it seems it's working.

@liZe liZe closed this as completed Oct 2, 2020
@liZe liZe added this to the 52 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature that should be supported good first issue Issues that can be quite easily solved by Python developers with a good CSS background
Projects
None yet
Milestone
52
Development

No branches or pull requests
3 participants
@liZe @muzzamilkhan @malnajdi