New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non ascii characters not supported in filename #32

Closed

Ph0tonic opened this issue Nov 14, 2024 · 0 comments · Fixed by #33

Contributor

Ph0tonic commented Nov 14, 2024

Hi,
The way header is set for filename doesn't support non ascii characters.

The following line manually adds an header :

Flask-WeasyPrint/flask_weasyprint/__init__.py

Line 201 in b3182cd

response.headers.add(

However, this line doesn't rely on flask which provides a way of returning filename containing utf-8 characters.

https://stackoverflow.com/questions/43365640/set-unicode-filename-in-flask-response-header

Maybe we could use flask base code instead of manually adding this header ?
Thanks

Ph0tonic mentioned this issue

Allow filename with non ascii characters #33

Merged

liZe closed this as completed in #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment