Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package names #47

Closed
05nelsonm opened this issue Jun 20, 2023 · 1 comment · Fixed by #48
Closed

Fix package names #47

05nelsonm opened this issue Jun 20, 2023 · 1 comment · Fixed by #48
Labels
bug Something isn't working

Comments

@05nelsonm
Copy link
Member

05nelsonm commented Jun 20, 2023

😢

See 05nelsonm/encoding#124

All modules in core have the same package name, so the same issue that Craig is running into with Java9 Module split packages would occur for anyone using JPMS where core is a direct or transitive dependency, too...

This would be a major breaking change.

@05nelsonm 05nelsonm added the bug Something isn't working label Jun 20, 2023
@05nelsonm
Copy link
Member Author

Since API needs to be broken, need to think of any other things that have been put off b/c of breakage and get them in now in order to only break this shit once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant