Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup reflective serializer lookup for common case by factor of 2.5 #952

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Speedup reflective serializer lookup for common case by factor of 2.5 #952

merged 1 commit into from
Jul 30, 2020

Conversation

qwwdfsad
Copy link
Member

No description provided.

sandwwraith
sandwwraith approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that this speedup is because of using getDeclaredMethod and getDeclaredField instead of .methods.find and declaredFields.find? Can you please add that to commit message?

@qwwdfsad
Copy link
Member Author

Indeed

@qwwdfsad qwwdfsad merged commit 5c1fdce into dev Jul 30, 2020
@qwwdfsad qwwdfsad deleted the speedup-serializer branch July 30, 2020 17:28
@qwwdfsad qwwdfsad mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @sandwwraith