Improve test for JVM intrinsics: #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old one used time-based approach. It was a good indicator, but in rare circumstances it may have been flaky and produced incorrect results. Flaky time-based tests are problematic for large builds, such as Kotlin's Aggregate build. New approach is based on cache presence and should not give incorrect results. See also #KTI-1726
shanshin
approved these changes
Apr 18, 2024
| @@ -43,4 +43,21 @@ class CachingTest { | |||
|
|
|||
| assertEquals(1, factoryCalled) | |||
| } | |||
|
|
|||
| @Serializable | |||
| class Target | |||
There was a problem hiding this comment.
There are no other branches of intrinsic, like value classes, e.t.c?
It may not be enough to check only the intrinsic of a regular class class Target
There was a problem hiding this comment.
There aren't any branches depending on class type. Either intrinsics are enabled and replacing serializer<T>() with something, or they are not. We have different branches for caches though (parametrized vs non-parametrized), but that is not what being tested here.
sandwwraith
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old one used time-based approach. It was a good indicator, but in rare circumstances it may have been flaky and produced incorrect results. Flaky time-based tests are problematic for large builds, such as Kotlin's Aggregate build.
New approach is based on cache presence and should not give incorrect results.
See also #KTI-1726