Add annotations from expect entity to actual entity. Required after KT-58551 #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
approved these changes
Aug 2, 2023
|
@woainikk, should these annotations be placed on the remaining actual |
sandwwraith
reviewed
Aug 2, 2023
| AnnotationTarget.VALUE_PARAMETER, | ||
| AnnotationTarget.LOCAL_VARIABLE, | ||
| AnnotationTarget.ANNOTATION_CLASS | ||
| ) | ||
| public actual annotation class FormatLanguage( |
There was a problem hiding this comment.
There's an actual annotation class FormatLanguage in JS source set, too
Also, what does the new rule says about actual typealias? We have this in JVM
There was a problem hiding this comment.
Fixed for Js source set.
"Annotations with retention SOURCE on expect are not checked if actual is typealias to compiled code." - and there is no compiler errors except error with FormatLanguage
There was a problem hiding this comment.
But kotlin.Target has default retention (runtime)
woainikk
force-pushed
the
bobova/fixForKT-58551
branch
from
a1f4067
to
07986e9
Compare
sandwwraith
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KT-58551