Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for encoding/deconding Properties as String #1158

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Add support for encoding/deconding Properties as String #1158

merged 3 commits into from
Oct 28, 2020

Conversation

daniel-jasinski
Copy link
Contributor

Implementation for issue 1152

@daniel-jasinski
Copy link
Contributor Author

@sandwwraith please take a look at this proposal for implementation.

sandwwraith
sandwwraith approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great PR! I think we can merge this after all the comments are addressed

formats/properties/commonMain/src/kotlinx/serialization/properties/Properties.kt Outdated Show resolved Hide resolved
formats/properties/commonMain/src/kotlinx/serialization/properties/Properties.kt Outdated Show resolved Hide resolved
formats/properties/commonMain/src/kotlinx/serialization/properties/Properties.kt Show resolved Hide resolved
formats/properties/commonMain/src/kotlinx/serialization/properties/Properties.kt Show resolved Hide resolved
sandwwraith
sandwwraith requested changes Oct 26, 2020
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@daniel-jasinski
Copy link
Contributor Author

Added changes according to the comments/suggestions. Please have a look.

@sandwwraith sandwwraith merged commit f08c62f into Kotlin:dev Oct 28, 2020
@sandwwraith
Copy link
Member

Note that it does not close #1152 because it takes Map<String, String>, not a whole single String

@daniel-jasinski daniel-jasinski deleted the properties-string-map branch October 29, 2020 01:59
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-jasinski @sandwwraith