Optimize check for missing fields in deserialization #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
requested changes
Oct 21, 2020
core/commonMain/src/kotlinx/serialization/SerializationException.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/internal/PluginUtils.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/internal/PluginUtils.kt
Outdated
Show resolved
Hide resolved
Now optimization turned off in compiler plugin to prevent fails. Anyway, the plugin should be improved |
shanshin
force-pushed
the
optimize-check-fields
branch
from
915374a
to
b96fe88
Compare
sandwwraith
approved these changes
Oct 29, 2020
| SerializationException("Field '$fieldName' is required, but it was missing") | ||
| internal class MissingFieldException : SerializationException { | ||
| // TODO: add (message, cause) ctor after 1.4.20 for coroutines stacktrace recovery | ||
| constructor(fieldName: String) : super("Field '$fieldName' is required, but it was missing") |
There was a problem hiding this comment.
The error in build is caused by the fact that old plugins can't find primary constructor of this class (because now it has two secondary constructors). In 1.4.20 this problem is fixed, so you may try to bump kotlin version to 1.4.20-M2
core/commonMain/src/kotlinx/serialization/SerializationException.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmTest/src/kotlinx/serialization/JvmMissingFieldsExceptionTest.kt
Outdated
Show resolved
Hide resolved
shanshin
force-pushed
the
optimize-check-fields
branch
2 times, most recently
from
834dd3b
to
5516e6d
Compare
shanshin
force-pushed
the
optimize-check-fields
branch
from
5516e6d
to
ecb852b
Compare
shanshin
force-pushed
the
optimize-check-fields
branch
2 times, most recently
from
3a13bf6
to
2f8de1f
Compare
sandwwraith
reviewed
Dec 24, 2020
| @@ -2,7 +2,7 @@ | |||
| # Copyright 2017-2020 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | |||
| # | |||
|
|
|||
| mainKotlinVersion=1.4.10 | |||
| mainKotlinVersion=1.4.30-M1 | |||
There was a problem hiding this comment.
Don't forget to change mainLibVersion to 1.1.0-SNAPSHOT so your optimizations will be enabled
shanshin
force-pushed
the
optimize-check-fields
branch
from
2f8de1f
to
b6298de
Compare
shanshin
force-pushed
the
optimize-check-fields
branch
from
b6298de
to
4d912ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.