-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readByteArray is broken #107
Comments
Even after my fix, the method is still broken. By contract, this method: kotlinx-io/core/commonMain/src/kotlinx/io/InputOperations.kt Lines 66 to 71 in fe899e0
should return the position after read (I don't know how it meant to know the position - it is private), but returns the number of bytes being read, so it works only when we are reading at the beginning of new buffer. Any suggestions? |
Closed
We're rebooting the kotlinx-io development (see #131), all issues related to the previous versions will be closed. Consider reopening it if the issue remains (or the feature is still missing) in a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kotlinx-io/core/commonMain/src/kotlinx/io/InputOperations.kt
Lines 64 to 65 in 2b54f00
This two statements together mean that returned array is always empty and pointer not advanced. I recommend adding tests for that.
The text was updated successfully, but these errors were encountered: