Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preprocessing] Split the Load preprocessing stage into two parts: LoadFile and LoadDir #227

Closed
zaleslaw opened this issue Sep 20, 2021 · 2 comments
Closed

[Preprocessing] Split the Load preprocessing stage into two parts: LoadFile and LoadDir #227

zaleslaw opened this issue Sep 20, 2021 · 2 comments
Assignees
@zaleslaw
Labels
invalid This doesn't seem right
Milestone
0.4

Comments

@zaleslaw
Copy link
Collaborator

We need to split the logic of loading into two parts. Now it's mixed and could be wrongly interpreted.
@zaleslaw zaleslaw added the enhancement New feature or request label Sep 20, 2021
@zaleslaw zaleslaw modified the milestones: 0.3, 0.4 Sep 20, 2021
@juliabeliaeva juliabeliaeva mentioned this issue Oct 4, 2021
Merged
@zaleslaw zaleslaw self-assigned this Oct 12, 2021
@zaleslaw
Copy link
Collaborator Author

Probably should be a part of the Dataset API

@zaleslaw zaleslaw added invalid This doesn't seem right and removed enhancement New feature or request labels Feb 25, 2022
@zaleslaw
Copy link
Collaborator Author

Now this logic is moved to the Dataset creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaleslaw zaleslaw

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
1 participant
@zaleslaw