Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K2] KMP: external keyword is not rendered for properties #3380

Closed
atyrin opened this issue Nov 27, 2023 · 1 comment · Fixed by #3613
Closed

[K2] KMP: external keyword is not rendered for properties #3380

atyrin opened this issue Nov 27, 2023 · 1 comment · Fixed by #3613
Assignees
@vmishenev
Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888

Comments

@atyrin
Copy link
Contributor

atyrin commented Nov 27, 2023

Declare in JS source set

external val x: String

K2 output is missing external
image

Installation

  • Dokka version: 1.9.20

Parent: #3328
@atyrin atyrin added bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888 labels Nov 27, 2023
@vmishenev vmishenev changed the title [K2] external keyword is not rendered [K2] external keyword is not rendered for properties Nov 30, 2023
@vmishenev vmishenev changed the title [K2] external keyword is not rendered for properties [K2] KMP: external keyword is not rendered for properties Dec 4, 2023
@IgnatBeresnev IgnatBeresnev mentioned this issue Dec 12, 2023
Open
12 tasks
@IgnatBeresnev
Copy link
Member

Technically, this needs to be investigated. Maybe the external keyword could be extracted from the getter, or maybe the compiler is not returning enough information

@vmishenev vmishenev self-assigned this May 14, 2024
@vmishenev vmishenev linked a pull request May 16, 2024 that will close this issue
[K2] Support external modifier for properties #3613
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmishenev vmishenev

Labels
bug topic: K2 Issues / PRs that are related to the K2 migration. See #2888
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[K2] Support external modifier for properties Kotlin/dokka
3 participants
@atyrin @vmishenev @IgnatBeresnev