Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Triggering infinitely when commented on closed PR #346

Closed
rekhansh opened this issue Sep 17, 2021 · 5 comments
Closed

Build Triggering infinitely when commented on closed PR #346

rekhansh opened this issue Sep 17, 2021 · 5 comments

Comments

@rekhansh
Copy link

Steps

  • setup jenkins project to trigger with comment 'test this' on PR and put some comment in end
  • now create a pr and close it
  • now comment
  • now jenkins trigger build again and again

GitHub PR Polling Log shows

Comment matched to pattern: state has changed (new comment found - 'test this')
Comment matched to pattern: matching comment test this

@KostyaSha
Copy link
Owner

Sound like you need first exclude not open PRs?

@rekhansh
Copy link
Author

Sound like you need first exclude not open PRs?

Not exactly,
the issue what I observed is - when pr is closed and any comment is added to pr, the plugin is not taking latest comment body from webhook

@podarok
Copy link

podarok commented Dec 9, 2021

Old bugging issue
Thank you for reporting

@KostyaSha
Copy link
Owner

Sound like you need first exclude not open PRs?

Not exactly, the issue what I observed is - when pr is closed and any comment is added to pr, the plugin is not taking latest comment body from webhook

plugin is not using webhooks body, it's quering API to get all comments in time of check

@rekhansh
Copy link
Author

rekhansh commented Jan 3, 2022

Duplicate of #332

@rekhansh rekhansh closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants