Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant availabilities #31

Open
margaretha opened this issue Dec 17, 2018 · 2 comments
Open

Redundant availabilities #31

margaretha opened this issue Dec 17, 2018 · 2 comments
Assignees

Comments

@margaretha
Copy link
Contributor

margaretha commented Dec 17, 2018

If a registered user requests a search, then changes a connection to VPN afterwards and resends the search, the availability rewrite will result in

image

This could be improved with a rewrite revert mechanism as described in the Kalamar issue KorAP/Kalamar#65.

@margaretha margaretha changed the title Availability rewrite bug Availability rewrite bug: redundant availabilities Dec 17, 2018
@margaretha margaretha changed the title Availability rewrite bug: redundant availabilities Redundant availabilities Dec 17, 2018
@margaretha
Copy link
Contributor Author

I have made some thoughts about the issue. I think the current approach with redundant availability rules is a safer and transparent way of rewrite.

Virtual corpus (Collection) Rewrites that have been done in a request is not considered in the next request. This is correct, because the next request includes the availability rules in a corpus query.

In fact, user sends the next request with the corpus query containing availability rules, even though they came originally from rewrite mechanism.

Merging new the availability rules is less safe because it may disregard a rule

for instance:

A request with login and corpus query

availability eq QAO-NC

this will be rewritten into

availability eq /CC.*/
or availability eq /ACA.*/
or availability eq /QAO-NC/

That would retrieve more documents than required.

It would be easier and clearer if the query and corpus query are simply reset after login/logout. VPN change is more complicated to detect...

@Akron
Copy link
Member

Akron commented Dec 13, 2024

I don't think I understand. So - you would argue that KorAP/Kalamar#65 is not prefered?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants