Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project alive? #68

Open
yaroslavkulinich opened this issue Sep 20, 2024 · 6 comments
Open

Is this project alive? #68

yaroslavkulinich opened this issue Sep 20, 2024 · 6 comments

Comments

@yaroslavkulinich
Copy link

No description provided.

@Konyaco
Copy link
Owner

Konyaco commented Sep 23, 2024

Yes, thanks to Sanlorng, it's still alive 😂

@Sanlorng
Copy link
Collaborator

No description provided.

#66 was merged

@yaroslavkulinich
Copy link
Author

@Konyaco @Sanlorng Thank you for a great project! I'm looking forward to the custom accent color support =)

@Sanlorng
Copy link
Collaborator

Sanlorng commented Sep 24, 2024

@Konyaco @Sanlorng Thank you for a great project! I'm looking forward to the custom accent color support =)

I've tried to support it, i can detect the windows theme changed event, but the fluent design color generation algorithm (dark1, dark2, dark3, light1, light2, light3) isn't exposed in the figma file.
image

@yaroslavkulinich
Copy link
Author

@Sanlorng Even this level of accent color support where users can specify custom colors would be a great step. System-level theme color detection is great but still a secondary feature I think.

@Sanlorng
Copy link
Collaborator

Sanlorng commented Jan 1, 2025

@Sanlorng Even this level of accent color support where users can specify custom colors would be a great step. System-level theme color detection is great but still a secondary feature I think.

What I want to say is that it is not just a simple accent color. The accent color value of the entire theme is derived from a base color into six colors: light 1, light 2, light 3, dark 1, dark 2, and dark 3. These six colors build the accent color experience of all components. Currently, the accent color derivation algorithm has not been exposed, which makes it impossible for us to implement the function of changing the accent color.
See color_generator and color_generator_expbranch, you can see some of the attempts we made on these two branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants