-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why request access to all URLs? #6
Comments
Hi, the reason I decided to use all URLs is that whenever I added new URLs before and pushed out an update, it would disable the extension for the users until they acknowledge the permission changes. This change just makes upgrading it a bit easier. |
That makes sense, and thanks for your reply and your great work on this plugin. But this change has made me more wary of the plugin and I've left it disabled since it updated, so a bit counterproductive maybe. I previously was happy to enable it without needing to look over the source code since it explicitly limited the sites it allowed itself to. My two cents, I think it would be better to go back to the old way of explicitly listing sites. |
Yeah, I can see where you're coming from on that. I'll keep that in consideration and will do that if there are more requests to go back to the old way. Thanks for your feedback. |
just noticed it today and honestly I prefer the old way also, just my 2c. |
Just pinging to mention I still have the extension disabled since this change. I'd love to see it reverted, but I understand it's more work from the developer side so I understand if it never is. |
Bump :B |
I'd still be interested in a version that didn't request access to all URLs. |
I made a fork to change that, though a few problems include it being unsigned and unavailable on add-on stores (AMO and CWS primarily), being disabled on every update, and not auto-updating. |
You just forgot to add an ID to the Firefox one. I can't install it, only as temporary in the about:debugging |
Oh, didn't know that. Will look into and should be able to push a release today. |
Thanks! |
Is there a limit to the number of URLs you can include in the manifest?
The text was updated successfully, but these errors were encountered: