Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why request access to all URLs? #6

Open
Nantris opened this issue Jun 27, 2022 · 11 comments
Open

Why request access to all URLs? #6

Nantris opened this issue Jun 27, 2022 · 11 comments

Comments

@Nantris
Copy link

Nantris commented Jun 27, 2022

Is there a limit to the number of URLs you can include in the manifest?

@Konnor88
Copy link
Owner

Hi, the reason I decided to use all URLs is that whenever I added new URLs before and pushed out an update, it would disable the extension for the users until they acknowledge the permission changes. This change just makes upgrading it a bit easier.

@Nantris
Copy link
Author

Nantris commented Jun 27, 2022

That makes sense, and thanks for your reply and your great work on this plugin.

But this change has made me more wary of the plugin and I've left it disabled since it updated, so a bit counterproductive maybe. I previously was happy to enable it without needing to look over the source code since it explicitly limited the sites it allowed itself to.

My two cents, I think it would be better to go back to the old way of explicitly listing sites.

@Konnor88
Copy link
Owner

Yeah, I can see where you're coming from on that. I'll keep that in consideration and will do that if there are more requests to go back to the old way. Thanks for your feedback.

@muchqs
Copy link

muchqs commented Jul 8, 2022

just noticed it today and honestly I prefer the old way also, just my 2c.
But i can see why this was done. I didn't notice it was disabled for days since the icon was hidden on the overflow bar.

@Nantris
Copy link
Author

Nantris commented Nov 2, 2022

Just pinging to mention I still have the extension disabled since this change. I'd love to see it reverted, but I understand it's more work from the developer side so I understand if it never is.

@boobthecat
Copy link

Bump :B

@Nantris
Copy link
Author

Nantris commented Jul 8, 2023

I'd still be interested in a version that didn't request access to all URLs.

@Realswitzer
Copy link

Realswitzer commented Jul 12, 2023

I'd still be interested in a version that didn't request access to all URLs.

I made a fork to change that, though a few problems include it being unsigned and unavailable on add-on stores (AMO and CWS primarily), being disabled on every update, and not auto-updating.
Any updates upstream, if I continue to maintain the fork, would likely end up being delayed too.
https://github.com/Realswitzer/anti-grabify/releases/latest

@boobthecat
Copy link

You just forgot to add an ID to the Firefox one. I can't install it, only as temporary in the about:debugging

@Realswitzer
Copy link

Realswitzer commented Jul 21, 2023

Oh, didn't know that. Will look into and should be able to push a release today.
Found the problem, was looking at source code and no ID was provided there which is what threw me off.

@boobthecat
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants