feat: add threshold line to timeseries charts [MA-3442] #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipgutica
requested changes
Nov 30, 2024
filipgutica
requested changes
Nov 30, 2024
filipgutica
requested changes
Nov 30, 2024
mihai-peteu
force-pushed
the
feat/ma-3442-analytics-chart-threshold
branch
from
3e14d7c to
e6ee577
Compare
filipgutica
requested changes
Dec 4, 2024
packages/analytics/dashboard-renderer/src/types/dashboard-renderer-types.ts
Outdated
Show resolved
Hide resolved
adorack
requested changes
Dec 4, 2024
| threshold: { | ||
| type: 'object', | ||
| properties: Object.fromEntries( | ||
| exploreAggregations.map((key) => [key, { type: 'number' }]), |
There was a problem hiding this comment.
This sort of dynamic definition is going to prevent TS inference from working. I don't have context on what this is trying to do; at the least trying to make this dynamic will be a journey with the way the current dashboard types are set up. Maybe just splat it out for now?
There was a problem hiding this comment.
This is what it yields:
I assume it's preferable to dynamically build the allowed keys rather than spelling out each one, and having to maintain this list separate from exploreAggregations.
We can simply make it {type: string}, {type: number}, but that seems too imprecise.
There was a problem hiding this comment.
Dropped the properties and just ended up doing
additionalProperties: {
type: 'number',
},
packages/analytics/dashboard-renderer/src/types/dashboard-renderer-types.ts
Outdated
Show resolved
Hide resolved
adorack
approved these changes
Dec 4, 2024
filipgutica
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/MA-3442
Analytics Chart
Dashboard Renderer