Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-vaults): fix kradio card occurrences #937

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Nov 21, 2023

Summary

Fix KRadio card occurrences in VaultsForm.vue (screenshots)

Before
Screen Shot 2023-11-21 at 3 29 43 PM

After
Screen Shot 2023-11-21 at 3 20 48 PM

PR Checklist

  • Naming & Structure: the files and package structure use the conventions outlined in the Creating a Package docs.
  • Tests pass: check the output of all package unit and/or component tests.
    • If this PR is the result of a bug, test coverage was added accordingly.
  • Functional: all changes do not break existing APIs, but if so, a BREAKING CHANGE commit is in place to bump the major version.
  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Docs: includes a technically accurate README, and the docs have been updated accordingly based on the changes in this PR.

@portikM portikM self-assigned this Nov 21, 2023
@portikM portikM requested review from kongponents-bot and a team as code owners November 21, 2023 20:31
Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@portikM portikM enabled auto-merge (squash) November 22, 2023 14:26
@portikM portikM merged commit 21827e9 into main Nov 22, 2023
29 checks passed
@portikM portikM deleted the fix/kongponents-alpha-fixes-0 branch November 22, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants