Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vfg): convert field-radio [khcp-11342] #1556

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

kaiarrowood
Copy link
Contributor

@kaiarrowood kaiarrowood commented Aug 14, 2024

Summary

Convert FieldRadio to use kongponents for KHCP-11342.

Adoption with passing E2Es: https://github.com/Kong/konnect-ui-apps/pull/3958

Resources

@kaiarrowood kaiarrowood self-assigned this Aug 14, 2024
sumimakito
sumimakito previously approved these changes Aug 15, 2024
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did functionality test and LGTM. Left a non-blocking comment

@kaiarrowood kaiarrowood force-pushed the feat/khcp-11342-vfg-field-radio branch from dd51da0 to 97e27f2 Compare August 15, 2024 19:24
@kaiarrowood kaiarrowood enabled auto-merge (squash) August 15, 2024 19:25
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiarrowood kaiarrowood merged commit 06e4c9d into main Aug 16, 2024
34 checks passed
@kaiarrowood kaiarrowood deleted the feat/khcp-11342-vfg-field-radio branch August 16, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants