Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(entities-certificates): remove snis if field not displayed #1528

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix(entities-certificates): remove snis if field not displayed #1528

merged 1 commit into from
Aug 2, 2024

Conversation

Leopoldthecoder
Copy link
Member

Summary

The request body should include the snis key only when the snis field is present.

Resources

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review August 2, 2024 03:44
@Leopoldthecoder Leopoldthecoder requested review from a team as code owners August 2, 2024 03:44
TT1228
TT1228 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@TT1228 TT1228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and verified it in sandbox, the fix works

@Leopoldthecoder Leopoldthecoder merged commit e934a33 into main Aug 2, 2024
7 checks passed
@Leopoldthecoder Leopoldthecoder deleted the fix/cert-form-snis branch August 2, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TT1228 TT1228 TT1228 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @TT1228