Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): redesigned RLA form [KM-136] #1416

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

sumimakito
Copy link
Member

@sumimakito sumimakito commented May 21, 2024

Summary

This PR adds the custom form layout for the RLA plugin:

Screenshot 2024-05-21 at 16 44 48

KM-136
KM-139

Adoption PR: https://github.com/Kong/konnect-ui-apps/pull/3275

@sumimakito sumimakito changed the title feat(plugins): redesigned RLA form feat(plugins): redesigned RLA form [KM-136] May 21, 2024
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

Create/edit flows working as expected for both scoped and unscoped 🚀

@sumimakito sumimakito force-pushed the feat/KM-136-rla-redesign branch from 6cb704c to d6ed866 Compare May 22, 2024 09:22
@sumimakito sumimakito force-pushed the feat/KM-136-rla-redesign branch from 16855ff to a7e3321 Compare May 23, 2024 18:44
@kaiarrowood kaiarrowood marked this pull request as ready for review May 23, 2024 19:08
@kaiarrowood kaiarrowood requested review from LukeSwierlik, QueaT-kong and a team as code owners May 23, 2024 19:08
Copy link
Contributor

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work @sumimakito 🚀 🚀

@kaiarrowood kaiarrowood merged commit 3a31000 into main May 23, 2024
8 checks passed
@kaiarrowood kaiarrowood deleted the feat/KM-136-rla-redesign branch May 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants