Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover with tests helpers from pkg/utils/kubernetes/networking/services.go #649

Closed
2 tasks done
programmer04 opened this issue May 10, 2023 · 0 comments · Fixed by #652
Closed
2 tasks done

Cover with tests helpers from pkg/utils/kubernetes/networking/services.go #649

programmer04 opened this issue May 10, 2023 · 0 comments · Fixed by #652
Assignees
@programmer04

Comments

@programmer04
Copy link
Member

programmer04 commented May 10, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Functions

  • WaitForServiceLoadBalancerAddress
  • WaitForConnectionOnServicePort

are considered as public API of this package and some other projects e.g. KIC relies on them. We should ensure that they work as expected.

Proposed Solution

Add tests for those functions.

Acceptance Criteria

  • Functions WaitForServiceLoadBalancerAddress and WaitForConnectionOnServicePort are tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@programmer04 programmer04

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@programmer04