Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin property "proxy_scheme" is unused #7640

Closed
Tieske opened this issue Mar 14, 2021 · 2 comments
Closed

plugin property "proxy_scheme" is unused #7640

Tieske opened this issue Mar 14, 2021 · 2 comments

Comments

@Tieske
Copy link
Member

Tieske commented Mar 14, 2021

The property is not used in the code since it is derived from the http request to make (always HTTPS in case of AWS Lambda). So the property should be removed from the schema.

This probably requires a migration.

@gszr gszr transferred this issue from Kong/kong-plugin-aws-lambda Aug 2, 2021
@Tieske
Copy link
Member Author

Tieske commented Sep 2, 2021

discussed with @bungle that removing fields do not need migrations, it's done automatically.

But it will break Konnect, since there is a mutually-required clause;

{ mutually_required = { "config.proxy_scheme", "config.proxy_url" } },

An option might be to first take out the mutually-required clause, and several versions later drop the field itself.

@gszr
Copy link
Member

gszr commented Mar 21, 2023

This was fixed by #8566.

@gszr gszr closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants