Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]Support knowing the credential type used for auth for logging purposes and to upstream API. #5933

Closed
jeremyjpj0916 opened this issue May 21, 2020 · 0 comments
Labels
task/feature Requests for new features in Kong

Comments

@jeremyjpj0916
Copy link
Contributor

jeremyjpj0916 commented May 21, 2020

Was glancing at this PR: #5516 and it got me thinking of another easy win feature to implement that may yield some decent return.

One thing downstream + logs do not collect was the auth pattern that was leveraged on a specific proxy transaction.

I propose an X-Authentication-Type header for upstream that all auth plugins set. Values would include:

oauth2
jwt
ldap
basic-auth
hmac

and so forth.

This idea spawns from potential analytics that can be gathered on what your most popular authentication traffic is during logging and any analysis that might be gleamed on which authentication types have the most latency or error rates etc. for further debugging.

Maybe set + get with the pdk and used in the standard Kong logs as well in basic serializer? The value can be derived from the plugins name from the conf honestly.

{
"auth": "oauth2"

or

"auth_type": "oauth2"

}

Thoughts?

@jeremyjpj0916 jeremyjpj0916 changed the title Support knowing the credential type used to the upstream/request context for logging purposes Support knowing the credential type used for auth for logging purposes and to upstream API. May 21, 2020
@jeremyjpj0916 jeremyjpj0916 changed the title Support knowing the credential type used for auth for logging purposes and to upstream API. [Feat]Support knowing the credential type used for auth for logging purposes and to upstream API. May 21, 2020
@kikito kikito added the task/feature Requests for new features in Kong label May 25, 2020
@guanlan guanlan closed this as completed May 26, 2021
@Kong Kong locked and limited conversation to collaborators May 26, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
task/feature Requests for new features in Kong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants