Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spin out plugins from the core #508

Closed
sonicaghi opened this issue Aug 26, 2015 · 4 comments
Closed

Spin out plugins from the core #508

sonicaghi opened this issue Aug 26, 2015 · 4 comments
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.

Comments

@sonicaghi
Copy link
Member

couldn't find the issue for this so I opened one.

@sonicaghi sonicaghi added the idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports. label Aug 26, 2015
@thibaultcha
Copy link
Member

No real need for one.

@Tieske
Copy link
Member

Tieske commented Aug 26, 2015

It depends whether you have a clear idea of what is considered "spin out"?

for example;

  • only interaction through the formal Kong lua based api? maybe a 'must' inherit from a base object?
  • make them standalone LuaRocks modules?
  • retain them in the same Kong repo, or their own repo?
  • duplicate utility functions in each plugin, or can they still access Kong modules?

I think some answers are required with respect to these before moving over to coding.

@thibaultcha
Copy link
Member

I take that back, this is actually a duplicate of #93.

@thibaultcha
Copy link
Member

Most of these have been answered internally:

only interaction through the formal Kong lua based api? maybe a 'must' inherit from a base object?

My thinking too

make them standalone LuaRocks modules?

Yes, for now while we still use luarocks that would be the fastest/simplest.

retain them in the same Kong repo, or their own repo?

Each in their own repo, though this does raise concerns like how to know if a push on Kong doesn't break something in one or several of the plugins since the integration tests of those will not run in Kong?

duplicate utility functions in each plugin, or can they still access Kong modules?

They can access the Kong modules and eventually we could have a module for shared utilities (like the spec_helper.lua module)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea/new plugin [legacy] those issues belong to Kong Nation, since GitHub issues are reserved for bug reports.
Projects
None yet
Development

No branches or pull requests

4 participants