Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate Limiting plugin concurrent problem #3329

Closed
zhkin opened this issue Mar 22, 2018 · 7 comments
Closed

Rate Limiting plugin concurrent problem #3329

zhkin opened this issue Mar 22, 2018 · 7 comments
Labels
pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc...

Comments

@zhkin
Copy link

zhkin commented Mar 22, 2018

Summary

Rate Limiting plugin concurrent problem

Steps To Reproduce

1.I create an API , then add a rate limiting plugin for it.
2.The plugin use Cluster strategy.
3.I use a concurrency test tool to test the api.The count is 1000.
4.I find the count is 985 in the database.

Additional Details & Logs

  • Kong version (0.10.3)
  • Postgres (latest)
@hishamhm
Copy link
Contributor

Hi @yczhaoDevelop, thank you for the report. Version 0.10.3 is really old -- can you reproduce this with the latest version?

@hishamhm hishamhm added the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Mar 29, 2018
@zhkin
Copy link
Author

zhkin commented Mar 30, 2018

@hishamhm, The kong's version is 0.13.0 and the postgresql's version is 9.5. The problem is still exist.I use Jmeter to test it. The Number of Threads is 1000. The Threads send at the same time.The access.log file has 1000 records,but 996 count in the ratelimiting_metrics table.

@zhkin
Copy link
Author

zhkin commented Apr 18, 2018

Hi @hishamhm, I really need your help.

@kikito
Copy link
Member

kikito commented May 23, 2018

Hi @yczhaoDevelop, could it be that 4 out of the 1000 requests didn't go through?

Please generate a dashboard report (https://jmeter.apache.org/usermanual/generating-dashboard.html) and see if there are any errors.

@p0pr0ck5
Copy link
Contributor

p0pr0ck5 commented Jul 7, 2018

This is a known behavior. See #2629 (among other issues, this has been discussed quite a bit in the past).

@cip123
Copy link

cip123 commented Jul 20, 2018

We have the same issue, what's worse an attacker can take down our system if it uses a lot of threads to perform requests. We have multiple Kong instances and PostgreSQL so we configured a 'cluster' policy.

Is there any other configuration that we can use to avoid it ?

@coopr
Copy link
Contributor

coopr commented Jul 20, 2018

@cip123 if you are seeking advice on configuring Kong's Rate Limiting, I suggest you post the details of your configuration and description of the problem you are trying to solve on Kong Nation https://discuss.konghq.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc...
Projects
None yet
Development

No branches or pull requests

7 participants