Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda Plugin Headers #2379

Closed
adamlc opened this issue Apr 12, 2017 · 3 comments · Fixed by #2823
Closed

Lambda Plugin Headers #2379

adamlc opened this issue Apr 12, 2017 · 3 comments · Fixed by #2823
Labels
task/feature Requests for new features in Kong

Comments

@adamlc
Copy link

adamlc commented Apr 12, 2017

Hey guys, great work on Kong! I have been evaluating the Lambda plugin for Kong.

During my testing I've found that none of the headers get passed over from Kong. I would have thought that any headers from the original request would be forwarded to lambda through the event? This seems to work for post data, but not headers :(

This would be particularly useful we so can extract the auth headers and http method 👍

@Tieske
Copy link
Member

Tieske commented Apr 12, 2017

Sounds to me as a great PR opportunity 😄

@p0pr0ck5 p0pr0ck5 added area/plugins task/feature Requests for new features in Kong labels Apr 18, 2017
@adamlc
Copy link
Author

adamlc commented Apr 27, 2017

Could well be! Although can't say I've ever developed with LUA before.

Do we think we should allow for custom headers, bodies / responses to be set too? I know in API gateway you can set mapping so that custom headers and responses can be sent. Not sure what the best way to do this would be and remain backwards compatible with the current behaviour.

@p0pr0ck5
Copy link
Contributor

@adamlc we'd certainly be happy to entertain various ideas and discussions in a PR, or on the mailing list or Gitter. GitHub issues, however, should be reserved for issues/problems/bugs while running Kong. Feel free to open a PR for this, or bring it up in the mailing list for further discussion. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task/feature Requests for new features in Kong
Projects
None yet
3 participants