Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response rate limiting plugin year length is 360 days #2021

Closed
peterbsmyth opened this issue Jan 26, 2017 · 3 comments
Closed

response rate limiting plugin year length is 360 days #2021

peterbsmyth opened this issue Jan 26, 2017 · 3 comments
Assignees
Labels

Comments

@peterbsmyth
Copy link

peterbsmyth commented Jan 26, 2017

Summary

The number of seconds for year translates to 360 days in policies line 20. 31104000 is 360 days, not 365.

@subnetmarco
Copy link
Member

subnetmarco commented Jan 26, 2017

You are correct, it should be 31536000. The mistake was done because for MONTH we are assuming 30 days and we just multiplied by 12 the month value, which turns out is 31104000 .

@subnetmarco subnetmarco self-assigned this Jan 26, 2017
@Tieske
Copy link
Member

Tieske commented Jan 26, 2017

so basically the month value should also be updated. If the period starts 15-Feb, it should measure 15-Februari up to 14-March. Not just a default of 30 days.

@subnetmarco
Copy link
Member

Yes currently it's a default of 30 days that begins at the beginning of the month (and beginning of second, minute, hour, and so on). This allows us to keep our data structure very simple, otherwise it would be too complex to store.

Generally speaking seems to be a good compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants