Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] Allow usage of the X-Forwarded-For header in the rate-limiting plugin #2012

Closed
jammm opened this issue Jan 24, 2017 · 2 comments
Closed

[plugin] Allow usage of the X-Forwarded-For header in the rate-limiting plugin #2012

jammm opened this issue Jan 24, 2017 · 2 comments

Comments

@jammm
Copy link

jammm commented Jan 24, 2017 •
edited
Loading

Similar to #1995, but for a different plugin (rate-limiting).

One approach I can think of is having an extra (optional) parameter specifying which header (real IP or X-FORWARDED-FOR) to use in case it falls back to IP as the identifier.
@bungle
Copy link
Member

bungle commented Mar 27, 2017

I'm pretty sure this is handled with #2236 / #2202.

@p0pr0ck5
Copy link
Contributor

Closing since #1995 was closed, as this was handled thanks to @bungle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bungle @jammm @p0pr0ck5