Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.6.x] fix: revert openresty ngx.req_body() stream process hardcode limitation #12666

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

team-gateway-bot
Copy link
Collaborator

Automated backport to release/3.6.x, triggered by a label in #12658.

Original description

Summary

Revert the hard-coded limitation of the ngx.read_body() API in OpenResty upstreams' new versions when downstream connections are in HTTP/2 and HTTP/3 stream modes.

upstream: openresty/lua-nginx-module#2286

Checklist

Issue reference

FTI-5766 FTI-5795

…oding limitation (#12658)

Cherry picked from openresty/lua-nginx-module#2286.

It was acknowledged by OpenResty as a mistaken breaking change, and
we should revert it.

FTI-5766
FTI-5795

(cherry picked from commit 55358df)
@oowl oowl requested a review from dndx February 29, 2024 08:57
@windmgc windmgc merged commit 19fbaa2 into release/3.6.x Mar 1, 2024
40 checks passed
@windmgc windmgc deleted the backport-12658-to-release/3.6.x branch March 1, 2024 02:53
@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x: couldn't find remote ref release/3.6.x.
Please ensure that this Github repo has a branch named release/3.6.x.

@team-gateway-bot
Copy link
Collaborator Author

Cherry-pick failed for release/3.6.x, because it was unable to create a new branch.

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream release/3.6.x
git worktree add -d .worktree/cherry-pick-12666-to-release/3.6.x-to-upstream upstream/release/3.6.x
cd .worktree/cherry-pick-12666-to-release/3.6.x-to-upstream
git checkout -b cherry-pick-12666-to-release/3.6.x-to-upstream
ancref=$(git merge-base 46af830e678f8d393bef7c78724d9877565cb689 4ab4d67ce8b0babd28e37dd24c26c550a77849ca)
git cherry-pick -x $ancref..4ab4d67ce8b0babd28e37dd24c26c550a77849ca

@AndyZhang0707 AndyZhang0707 removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants