-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add ngx_brotli module #12367
Conversation
Is (or will be) there a sister PR for the docs repo? |
Where can I add brotli compress feature doc? It seems our doc has not described anything related to the nginx inject Nginx Directives list. https://docs.konghq.com/gateway/latest/reference/nginx-directives/ |
Could you run a full matrix test build to verify the manifests are all correct? Like the one here #11629 (comment) |
https://github.com/Kong/kong/actions/runs/7579992609 |
compiler ld failed in the master branch, So I switched to the google rc version. https://github.com/Kong/kong/actions/runs/7580586355/job/20646664578#step:18:1891 |
All matrix test has been passed, So I revert ae1564c |
This reverts commit ae1564c.
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12367-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12367-to-master-to-upstream
git checkout -b cherry-pick-12367-to-master-to-upstream
ancref=$(git merge-base f0ba93044a73ab3d4191367e2fcac76fa0d06b7e 16e8742e01eafbcc21313aa66920465de3a8f83c)
git cherry-pick -x $ancref..16e8742e01eafbcc21313aa66920465de3a8f83c |
It seems you are right, we don't have these features documented anywhere. I got late to the party, but LGTM 😄🚀 |
Summary
add ngx_brotli module to Kong prebuilt Nginx binary. So we can use these configs in kong configure to support brotli compression feature in Kong.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-2477