perf(tracing): avoid unnecessary creations and garbage-collections of spans (from timers) #12080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
changed the title
samugi
force-pushed
the
perf/tracing-timer-phase
branch
from
12d7a80 to
09d14f8
Compare
|
I'm open to suggestions in case there is a faster way to detect that we are in a timer context |
samugi
changed the title
samugi
force-pushed
the
perf/tracing-timer-phase
branch
4 times, most recently
from
895af6c to
d68b77e
Compare
Before this change timers would generate spans, which means DB and DNS spans in recurring timers would be continuously generated and garbage-collected. This commit checks the exact ngx phase and runs it against a whitelist to ensure `timer` phase does not generate spans.
samugi
force-pushed
the
perf/tracing-timer-phase
branch
from
d68b77e to
dfe0b50
Compare
chobits
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this change timers would generate spans, which means DB and DNS spans in recurring timers would be continuously generated and garbage-collected.
This commit checks the exact ngx phase and runs it against a whitelist of allowed phases to ensure the
timerphase does not generate spans.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
KAG-3169