fix(dns): set default dns_no_sync to on
#11869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
force-pushed
the
fix/enable_dns_no_sync
branch
from
c8ecbdb to
9c44f02
Compare
This is a temporary fix for the DNS resolution blocking issue. If the issue is resolved, remember to revert this option to `off`. Fix FTI-5348
chobits
force-pushed
the
fix/enable_dns_no_sync
branch
from
9c44f02 to
c36eb8c
Compare
dndx
approved these changes
Oct 27, 2023
bungle
approved these changes
Oct 27, 2023
team-gateway-bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
This is a temporary workaround for the DNS client blocking issue until a more permanent solution can be developed. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]> (cherry picked from commit 3be2513)
dndx
pushed a commit
that referenced
this pull request
Oct 27, 2023
This is a temporary workaround for the DNS client blocking issue until a more permanent solution can be developed. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]> (cherry picked from commit 3be2513)
3 tasks
1 task
dndx
added a commit
that referenced
this pull request
Nov 15, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
chobits
added a commit
that referenced
this pull request
Nov 15, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
3 tasks
chobits
added a commit
that referenced
this pull request
Nov 16, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
chobits
added a commit
that referenced
this pull request
Nov 16, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
chobits
added a commit
that referenced
this pull request
Nov 16, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
bungle
pushed a commit
that referenced
this pull request
Nov 16, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
bungle
pushed a commit
that referenced
this pull request
Nov 16, 2023
…adlock risk (#11900) * Revert "fix(conf): set default value of `dns_no_sync` to `on` (#11869)" This reverts commit 3be2513. * fix(dns): introduce the synchronous query in syncQuery() to prevent hang risk Originally the first request to `syncQuery()` will trigger an asynchronous timer event, which added the risk of thread pool hanging. With this patch, cold synchronously DNS query will always happen in the current thread if current phase supports yielding. Fix FTI-5348 --------- Co-authored-by: Datong Sun <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a temporary fix for the DNS resolution blocking issue. If the issue is resolved, remember to revert this option to
off.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix FTI-5348