[reopened] feat(request-id): introduce Request ID #11663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dndx
force-pushed
the
feat/request-id-phase-1
branch
from
c652620 to
3e5ac5d
Compare
ADD-SP
requested changes
Sep 27, 2023
chobits
reviewed
Sep 27, 2023
samugi
force-pushed
the
feat/request-id-phase-1
branch
from
3e5ac5d to
9d6115b
Compare
dndx
commented
Sep 27, 2023
ADD-SP
requested changes
Sep 27, 2023
samugi
force-pushed
the
feat/request-id-phase-1
branch
from
9d6115b to
11b0962
Compare
samugi
force-pushed
the
feat/request-id-phase-1
branch
from
11b0962 to
2d3d0f1
Compare
chobits
reviewed
Sep 27, 2023
samugi
force-pushed
the
feat/request-id-phase-1
branch
2 times, most recently
from
65405a4 to
fa61dad
Compare
ADD-SP
previously requested changes
Sep 28, 2023
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
samugi
added a commit
that referenced
this pull request
Nov 9, 2023
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: samugi <[email protected]>
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
3 tasks
samugi
added a commit
that referenced
this pull request
Nov 15, 2023
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
samugi
added a commit
that referenced
this pull request
Nov 15, 2023
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: samugi <[email protected]>
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
samugi
added a commit
that referenced
this pull request
Nov 15, 2023
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
samugi
added a commit
that referenced
this pull request
Nov 20, 2023
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: samugi <[email protected]>
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
2 tasks
outsinre
added a commit
that referenced
this pull request
Nov 22, 2023
Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value.
samugi
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments
team-gateway-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments (cherry picked from commit 9ec3494)
outsinre
added a commit
that referenced
this pull request
Nov 28, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments
fffonion
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments (cherry picked from commit 9ec3494)
fffonion
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments
3 tasks
AndyZhang0707
added a commit
that referenced
this pull request
Jul 18, 2024
This reverts commit edf1835.
AndyZhang0707
added a commit
that referenced
this pull request
Jul 26, 2024
This reverts commit edf1835.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce Request ID that:
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdFull changelog
Issue reference
KAG-2034
FTI-4837