Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cp): add dp metadata on prem (KAG-2444) #11625

Merged
merged 6 commits into from
Sep 26, 2023
Merged

feat(cp): add dp metadata on prem (KAG-2444) #11625

merged 6 commits into from
Sep 26, 2023

Conversation

gruceo
Copy link
Contributor

@gruceo gruceo commented Sep 20, 2023 •
edited
Loading

Summary

KAG-2444

Checklist

@gruceo gruceo force-pushed the feat/KAG-2444-dp_metadata_on_prem branch from 0480b78 to 3771dfc Compare September 20, 2023 20:10
@gruceo gruceo marked this pull request as ready for review September 20, 2023 20:35
@gruceo gruceo requested a review from samugi September 20, 2023 20:40
samugi
samugi reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@samugi samugi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works, looks good to me, just 2 minor comments.

spec/02-integration/03-db/13-cluster_status_spec.lua Show resolved Hide resolved
spec/02-integration/09-hybrid_mode/01-sync_spec.lua Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 25, 2023
@gruceo gruceo requested a review from samugi September 25, 2023 18:26
@samugi samugi mentioned this pull request Sep 26, 2023
Merged
2 tasks
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Sep 26, 2023
@samugi samugi removed the author/community PRs from the open-source community (not Kong Inc) label Sep 26, 2023
@samugi samugi merged commit 894206b into master Sep 26, 2023
@samugi samugi deleted the feat/KAG-2444-dp_metadata_on_prem branch September 26, 2023 14:26
@gruceo gruceo added this to the 3.5.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samugi samugi samugi approved these changes

Assignees

@gruceo gruceo

Labels
core/clustering core/db/migrations core/db schema-change-noteworthy size/L
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@gruceo @CLAassistant @samugi @team-eng-enablement @RobSerafini