Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Do not encode sub-delim characters in query part of URL #604

Closed
oliverjanik opened this issue Nov 16, 2017 · 2 comments
Closed

[Bug] Do not encode sub-delim characters in query part of URL #604

oliverjanik opened this issue Nov 16, 2017 · 2 comments

Comments

@oliverjanik
Copy link

  • Insomnia Version: 5.11.5
  • Operating System: Win 10

Details

When I sent a get request like this

https://example.com/test?limit(1,1)

Insomnia encodes the comma character for me. And the request ends up being this:

https://example.com/test?limit(1%2C1)

Please note that Postman does not do this, neither do any HTTP clients that I tried (C# HttpClient, Angular 4 Http service)

If I'm reading the RFC right the comma is a sub-delim and is fully allowed within query part of URL.

https://tools.ietf.org/html/rfc3986#section-3.4

@gschier
Copy link
Contributor

gschier commented Nov 16, 2017

There was a similar question in #592 about encoding the $. It seems like the best solution to this may be to have URL encoding be configurable.

@gschier
Copy link
Contributor

gschier commented Nov 16, 2017

Going to close this in favor of #605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants