Avoid SIGSEGV in tromp solver #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
force-pushed
the
jmj_tromp_maxsols
branch
from
f7d6d25 to
7f89ac3
Compare
|
looks good |
DeckerSU
reviewed
Aug 1, 2022
| break; | ||
| } | ||
| } | ||
| check_tromp_solution(eq, validBlock); |
There was a problem hiding this comment.
May be here we need:
if (check_tromp_solution(eq, validBlock))
break;
To preserve the original logic? If we find a POW solution, do not try other solutions.
There was a problem hiding this comment.
As I can tell, check_tromp_solution does not change the original logic:
the original logic breaks the loop if a solution is found
and check_tromp_solution in this case just returns also breaking solution searching.
It looks like the boolean return is needed for tests only
There was a problem hiding this comment.
Yes, seems you are right, sorry. The logic is fine.
p.s. It was "small display issue" (I mixed up the scopes somehow and what it breaks).
ca333
approved these changes
Aug 5, 2022
Alrighttt
approved these changes
Aug 8, 2022
DeckerSU
added a commit
to DeckerSU/KomodoOcean
that referenced
this pull request
Aug 16, 2022
|
LGTM.
|
DeckerSU
approved these changes
Aug 16, 2022
nuttycom
pushed a commit
to zcash/zcash
that referenced
this pull request
Aug 23, 2022
|
these changes implemented in combined PR: #559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #555
The tromp equihash solver can sometimes get in the state whereby the nsols counter is greater than MAXSOLS. An attempt is then made to read an element of the array beyond the array size (index out of bounds). This fix limits the reads to a maximum of MAXSOLS.
TODO: