Replace ASSETCHAINS_SYMBOL with class #509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmjatlanta
force-pushed
the
jmj_assetchains_symbol
branch
from
16b35b4 to
69dc615
Compare
|
While I believe this PR to be a step in the right direction, I recommend migrating to something within the |
|
these changes implemented in combined PR: #559 |
Alrighttt
pushed a commit
to Alrighttt/komodo
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hope is to add more assetchain information into the class, with the ultimate goal of removing many of the related globals.
Other advantages (IMO):
ASSETCHAINS_SYMBOL[0] == 0vschain.isKMD())NOTE: This builds on the
jmj_header_declarationsbranch, so either merge that one first (easier review) or close that one and merge this one (harder review).