Renamer: <baseFileName> includes File Extension (.mkv)

[hologarden]

Describe the bug
See title.

To Reproduce
Steps to reproduce the behavior:

1. Find unfulfilled movie with no data
2. 'Load information' > follow through with saving metadata
3. Save metadata using 'Save' button
4. NFO and images renamed with movie title ie. 映画 聲の形 (2016).mkv.nfo instead of 映画 聲の形 (2016).nfo

Expected behavior
See step 4 of reproduction.

Screenshots
If applicable, add screenshots to help explain your problem.

MediaElch Version:

• 2.12.0 (stable)

Operating System:

• Windows

Additional context
I have only recently updated to 2.12.0, though I don't know what previous version I had. This behavior is either newly intended or unintentional, but either way Jellyfin does not like it and it has messed with applying metadata to new entries.

[hologarden]

Would also like to add that i've used linuxserver/docker-mediaelch as well to see if this particularly pertains to Windows 11, however it is replicable there as well under the same conditions.

In my particular case, I have multiple versions of a film: US and Japanese. Here, the Japanese version has full metadata, but neither Windows nor Docker versions recognize the JP version, though they have previously merged under one entry (Pokemon 3, with a dropdown showing US and JP filepaths)

The scanner for MediaElch correctly correlates the US and JP versions together, however shows the filepath for the US version. When saving, it saves the metadata for the JP release.

For example:

[bugwelle]

Hi,

thanks for reporting!

I can't reproduce it (yet). Could you tell me more about your file names and post them here? Do you separate your movies by folders?

Your screenshot in your second post does not have the issue your described in your first one.

Does your movie's filename have another extension such as movie-title.mkv.mkv? On Windows, you have to explicitly enable file extensions to be shown (but looking at your screenshot, you've already done that).

The logic for the "baseFileName" relies on Qt, the UI framework we use. It uses completeBaseName() which strips the filename. I currently do not see how an extension can up in the NFO's filename.

Regards,

Andre

[hologarden]

Sorry for the confusion, the files you see in my second comment were manually edited to remove the .mkv append that the issue relates to.

Do you separate your movies by folders?

Yes, as so:

Does your movie's filename have another extension such as movie-title.mkv.mkv? On Windows, you have to explicitly enable file extensions to be shown (but looking at your screenshot, you've already done that).

As you can guess, yes, for this specific reason I have enabled it in Windows to ensure that this doesn't happen but also to make filetypes transparent without relying on Explorer itself to guess what it is (sometimes it applies, for example 'Adobe Acrobat PDF' if Acrobat is installed instead of just 'PDF')

Here is a previously saved film, por example:

And its files, from when they were added to ME:

I'm not familiar with Qt, however it is strange the issue is replicable for me both on Windows and Linux (through linuxserver/docker-mediaelch). After some testing though, I introduce a strange problem that amends it:

By isolating the film, on my Desktop in a folder named _test, with it's own folder, making the filepath:
C:\Users\leader\Desktop\_test\劇場版ポケットモンスター 結晶塔の帝王 ENTEI (2000)

MediaElch successfully writes the new metadata without the file extension appended.

So perhaps this is related to filepath length somehow?

[hologarden]

Ah, I've found the exact issue at hand, which relates to multiple film versions.

When removing the second version (which is what MediaElch first displays, as below), this is the output:

When adding the second version back into the directory:

So at the end of the day this is technically user error, however what would be the best way to amend this? Is it intended behavior by MediaElch to make the metadata unique for each version (even though it displays the US Release first)?

[bugwelle]

Oh, wow!

Thank you very much for reproducing the issue!

mkdir my-movie && cd $_
touch my-movie-us.mkv my-movie-jap.mkv

1. Reload movies
2. Select "my-movie"
3. load some data
4. save
5. See invalid filenames:

.
├── my-movie-jap.mkv
├── my-movie-jap.mkv-banner.jpg
├── my-movie-jap.mkv-clearart.png
├── my-movie-jap.mkv-clearlogo.png
├── my-movie-jap.mkv-discart.png
├── my-movie-jap.mkv-fanart.jpg
├── my-movie-jap.mkv-landscape.jpg
├── my-movie-jap.mkv.nfo
├── my-movie-jap.mkv-poster.jpg
└── my-movie-us.mkv

@hologarden In my opinion, this is a bug. Interestingly, there is a TODO note in the code about file extensions, where I've linked to #1175

That means I will have to double check the logic and will need to check that I don't introduce an old bug again.
If I fix the issue, it could be that banners and other files are no longer found, hence I need to be careful.

There is currently nothing you can do.