Add endpoint capability to lock type #25359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require device 'Garage door with lock (GADOLOCK)' added in zhc:src/devices/custom_devices_diy.ts with PR Koenkk/zigbee-herdsman-converters#8529
|
This should be implemented for an actual device, not a dummy one.
|
This device does not fulfill zhc policy because it does not exist in real life. This reverts commit 13a5f7c.
|
✅ Dummy garage door and lock device model GADOLOCK removed in zhc custom_devices_diy (Koenkk/zigbee-herdsman-converters@df76d75) |
Zitrium31
commented
Jan 2, 2025
No lock with endpoint available at the time being Tested locally with a DIY lock device made of several endpoints
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this change:
homeassistant.tsadd test for home assistant discovery config for such device with made of several endpoints using_statekey intoZigbeeconverter : _onOff, windowCovering, lockIn short, this change supplements issue #24352 for lock.
Prerequisite : Added tests required the dummy garage door and lock device modelGADOLOCKincustom_devices_diydefinitions with PR #8529 in ZHC repo.🙂 Thanks in advance for the review of this PR. Should you have any remark, please ask.