Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups added with bridge/config/add_group are missing the 'retain' property #2264

Closed
sjorge opened this issue Nov 3, 2019 · 3 comments
Closed

Comments

@sjorge
Copy link
Contributor

sjorge commented Nov 3, 2019

Bug Report

What happened

Added a test group by publishing
test to zigbee2mqtt/bridge/config/add_group, this resulted in

groups:
  '1':
    friendly_name: 'test'

To be added to the configuration (so far so good), however on restart zigbee2mqtt fails to start with the following error:

zigbee2mqtt:error 2019-11-03T19:38:49: Refusing to start, configuration.yaml is not valid, found the following errors:
zigbee2mqtt:error 2019-11-03T19:38:49:   - groups['1'] should have required property 'retain

This makes sense as 'retain' seems to be a required property for groups.

What did you expect to happen

The group to have retain set to either 0 or 1

How to reproduce it (minimal and precise)

Add a new group via mqtt

Debug Info

zigbee2mqtt version: 1.6.0 @ dev from 20191103
CC253X firmware version: n/a

@sjorge
Copy link
Contributor Author

sjorge commented Nov 3, 2019

I'll see if I can fix this while I am adding support for creating a group with an id set.

@sjorge
Copy link
Contributor Author

sjorge commented Nov 3, 2019

I have a fix for this, will open PR for feedback in a bit...

@sjorge
Copy link
Contributor Author

sjorge commented Nov 4, 2019

Now fixed after PR #2266 got merged

@sjorge sjorge closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant