Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bind/unbind logic. #1144

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Improve bind/unbind logic. #1144

merged 2 commits into from
Aug 9, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Aug 8, 2024

  • Check if bind exists before triggering unbind request.
  • Ensure group ID exists when unbinding with number (always created when addBinding/bind, so should always exist).
  • Add internal addBinding function to avoid cluster lookup when available in caller.
  • Optimize getters.

@Koenkk Koenkk merged commit a3aeb33 into Koenkk:master Aug 9, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Aug 9, 2024

Thanks!

@Nerivec Nerivec deleted the bind-unbind branch August 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants