Add converter for modern moes bht-006 thermostat

[dukobpa3]

Fixed mapping issues described here
Introduced new one converter for this device (mostly copypaste from previous)

Koenkk/zigbee2mqtt#24001

[dukobpa3]

Is it reasonable to remake it in modern style?

[Koenkk]

That will require quite some changes, it's fine if you add just the expose definition to the existing BHT-002-GCLZB

[dukobpa3]

That will require quite some changes, it's fine if you add just the expose definition to the existing BHT-002-GCLZB

there is different definitions. That's the issue.

– different controls for deadzone and max temp (45-70 vs 0-45) – in current defined 3 points. 2 of them wrong for this thermostat 3-d is not using at all.
– all controls should be integer not float
– different limits, steps and enum values in exposes.

I can try to make one definition but there will be spaghetti with a lot of if/elses

[dukobpa3]

@Koenkk
Ok lets do this way

[Koenkk]

max_temperature_limit to be in sync with the min_temperature_limit below

[dukobpa3]

check lines 1127 and 1129

[Koenkk]

Can you update moes_thermostat_max_temperature_limit instead? Use the correct datapoint

[dukobpa3]

it is 18 but needed 19

[dukobpa3]

Different points for most devices and this one

                device?.manufacturerName === '_TZE204_aoclfnxz'
                    ? e.max_temp().withValueMin(45).withValueMax(70)
                    : e.max_temperature_limit().withValueMax(45),

[Koenkk]

But you can do an if/else in moes_thermostat_max_temperature_limit:

if (device?.manufacturerName === '_TZE204_aoclfnxz') {
  // send to 19
} else {
  // send to 18
}

[dukobpa3]

Two layers of checking manufacturer name looks like layered spaghetty ))

But I'll look to it, ok

[dukobpa3]

Ok but then reasonable to do the same with deadzone

[dukobpa3]

So will you merge it? Or do you need some other changes?

[Koenkk]

This comment is still left; #8005 (comment)

[Drafteed]

This should be reverted: #8063 (comment)

[Koenkk]

Could you make a PR to revert it? Reverting through GH is not possible anymore because of conflicts.

[dukobpa3]

Ok I will

But what should I do with my device then?

[Drafteed]

Wonder if is it possible to check the fw version of Tuya devices in converters?

[dukobpa3]

I don't know but sure there definitely should be some differences. Moes/Tuya apps can recognise them somehow...

[Koenkk]

Could you both post the data/database.db entries of your device?

[Drafteed]

@Koenkk

{
  "id": 25,
  "type": "Router",
  "ieeeAddr": "0xa4c138f863cdfe54",
  "nwkAddr": 16945,
  "manufId": 4417,
  "manufName": "_TZE204_aoclfnxz",
  "powerSource": "Mains (single phase)",
  "modelId": "TS0601",
  "epList": [
    1,
    242
  ],
  "endpoints": {
    "1": {
      "profId": 260,
      "epId": 1,
      "devId": 81,
      "inClusterList": [
        4,
        5,
        61184,
        0
      ],
      "outClusterList": [
        25,
        10
      ],
      "clusters": {
        "genBasic": {
          "attributes": {
            "65503": "�\u001f�.i�\u001f�.i�\u001f�.i�\u001f�.i�\u001f�.i�\u001f�.i�\u001f�.i�\u001f�.i",
            "65506": 56,
            "65508": 0,
            "modelId": "TS0601",
            "manufacturerName": "_TZE204_aoclfnxz",
            "powerSource": 1,
            "zclVersion": 3,
            "appVersion": 74,
            "stackVersion": 0,
            "hwVersion": 1,
            "dateCode": ""
          }
        }
      },
      "binds": [],
      "configuredReportings": [],
      "meta": {}
    },
    "242": {
      "profId": 41440,
      "epId": 242,
      "devId": 97,
      "inClusterList": [],
      "outClusterList": [
        33
      ],
      "clusters": {},
      "binds": [],
      "configuredReportings": [],
      "meta": {}
    }
  },
  "appVersion": 74,
  "stackVersion": 0,
  "hwVersion": 1,
  "dateCode": "",
  "zclVersion": 3,
  "interviewCompleted": true,
  "meta": {},
  "lastSeen": 1728133559440
}

[dukobpa3]

{
  "id": 22,
  "type": "Router",
  "ieeeAddr": "0xa4c138baa855a68a",
  "nwkAddr": 42956,
  "manufId": 4417,
  "manufName": "_TZE204_aoclfnxz",
  "powerSource": "Mains (single phase)",
  "modelId": "TS0601",
  "epList": [
    1,
    242
  ],
  "endpoints": {
    "1": {
      "profId": 260,
      "epId": 1,
      "devId": 81,
      "inClusterList": [
        4,
        5,
        61184,
        0
      ],
      "outClusterList": [
        25,
        10
      ],
      "clusters": {
        "genBasic": {
          "attributes": {
            "65503": "$ܓ.g",
            "65506": 56,
            "65508": 0,
            "modelId": "TS0601",
            "manufacturerName": "_TZE204_aoclfnxz",
            "powerSource": 1,
            "zclVersion": 3,
            "appVersion": 74,
            "stackVersion": 0,
            "hwVersion": 1,
            "dateCode": ""
          }
        }
      },
      "binds": [],
      "configuredReportings": [],
      "meta": {}
    },
    "242": {
      "profId": 41440,
      "epId": 242,
      "devId": 97,
      "inClusterList": [],
      "outClusterList": [
        33
      ],
      "clusters": {},
      "binds": [],
      "configuredReportings": [],
      "meta": {}
    }
  },
  "appVersion": 74,
  "stackVersion": 0,
  "hwVersion": 1,
  "dateCode": "",
  "zclVersion": 3,
  "interviewCompleted": true,
  "meta": {},
  "lastSeen": 1728133642460
}

[Drafteed]

[Drafteed]

It looks like we need to look for differences in the data points, I think there is some value there indicating the revision of device.