Update GL-D-013P #7860
Merged
Update GL-D-013P #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you check if the transitions still work correctly. Especially if the time of the transition is correct. |
|
Seems to be working correctly. When setting transition to 1, the light gradually turns on and off over 1 second period. Setting it to 5, it smoothly turns on and off over 5 seconds period. Anything else to check? |
|
Nope, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively adds supported Identify and Power-on-behavior features while retaining all functionality. Tested on GL-D-013P but it may be applicable to other Gledopto lights as there are many similar ones, but I only have this one and can't test it.