Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ignore error when binding to manuSpecificPhilips2 #7814

Merged

Conversation

LaurentvdBos
Copy link
Contributor

@LaurentvdBos LaurentvdBos commented Aug 1, 2024

I have a Philips Signe Floor light (Zigbee device 915005987201) that can show fancy gradients. This one shows errors in the log that look like follows:

Aug 01 21:36:18 bossteegje poddos[9695]: [2024-08-01 21:36:18] z2m: Failed to configure 'Staaflamp', attempt 1 (Error: Bind 0x001788010c53faec/242 manuSpecificPhilips2 from '0xe0798dfffeb785a0/1' failed ([ZDO] Failed response by NCP for "7207" cluster "32801" with status=ZDP_INVALID_ENDPOINT.)
Aug 01 21:36:18 bossteegje poddos[9695]:     at EmberOneWaitress.resolveZDO (/app/node_modules/zigbee-herdsman/src/adapter/ember/adapter/oneWaitress.ts:138:35)
Aug 01 21:36:18 bossteegje poddos[9695]:     at EmberAdapter.onZDOResponse (/app/node_modules/zigbee-herdsman/src/adapter/ember/adapter/emberAdapter.ts:663:26)
Aug 01 21:36:18 bossteegje poddos[9695]:     at Ezsp.emit (node:events:517:28)
Aug 01 21:36:18 bossteegje poddos[9695]:     at Ezsp.ezspIncomingMessageHandler (/app/node_modules/zigbee-herdsman/src/adapter/ember/ezsp/ezsp.ts:4517:22)
Aug 01 21:36:18 bossteegje poddos[9695]:     at Ezsp.callbackDispatch (/app/node_modules/zigbee-herdsman/src/adapter/ember/ezsp/ezsp.ts:820:18)
Aug 01 21:36:18 bossteegje poddos[9695]:     at Ezsp.tick (/app/node_modules/zigbee-herdsman/src/adapter/ember/ezsp/ezsp.ts:446:22)
Aug 01 21:36:18 bossteegje poddos[9695]:     at listOnTimeout (node:internal/timers:569:17)
Aug 01 21:36:18 bossteegje poddos[9695]:     at processTimers (node:internal/timers:512:7))

This only happens when using the ember adapter, and not with the ezsp adapter (I have a ZBDongle-E). I guess this is because the ember adapter throws an error when a bind fails and ezsp silently ignores that, however, I am not sure.
It is known (and documented in the documentation of the bulb) that it does not expose the gradient, so it is not entirely unexpected that this bind fails.

So before merging this, is there somebody with a Philips bulb with gradient support that sees similar behavior?

I also did not dare yet to test this fix. Is there a quick-and-dirty way of swapping my zigbee-herdsman-converters in my running container installation or should I then completely rebuild zigbee2mqtt to test this?

src/lib/philips.ts Outdated Show resolved Hide resolved
@Koenkk Koenkk marked this pull request as ready for review August 5, 2024 19:29
@Koenkk Koenkk merged commit e841249 into Koenkk:master Aug 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants